Skip to content

HybridCompute - Add stable api 2019-12-12 swagger#8095

Merged
yungezz merged 18 commits intoAzure:masterfrom
dkirby017:master
Jan 22, 2020
Merged

HybridCompute - Add stable api 2019-12-12 swagger#8095
yungezz merged 18 commits intoAzure:masterfrom
dkirby017:master

Conversation

@dkirby017
Copy link
Copy Markdown
Member

@dkirby017 dkirby017 commented Jan 8, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jan 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 8, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 8, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 8, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 87808a6 with merge commit 53428a5. SDK Automation 13.0.17.20191226.1 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 8, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 87808a6 with merge commit 53428a5. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.HybridCompute [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation Bot commented Jan 8, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]

    yungezz
    yungezz reviewed Jan 9, 2020
    View reviewed changes
    Copy link
    Copy Markdown
    Member

    @yungezz yungezz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    pls add missing examples.

    Comment thread .../hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2019-12-12/HybridCompute.json Outdated
    @yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 9, 2020
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 9, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 9, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 9, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    ryansbenson
    ryansbenson reviewed Jan 10, 2020
    View reviewed changes
    Copy link
    Copy Markdown
    Contributor

    @ryansbenson ryansbenson left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Minor change requested.

    Comment thread .../hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2019-12-12/HybridCompute.json Outdated
    Comment thread .../hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2019-12-12/HybridCompute.json Outdated
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 10, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azuresdkci
    Copy link
    Copy Markdown
    Contributor

    azuresdkci commented Jan 13, 2020

    Can one of the admins verify this patch?

    @yungezz
    Copy link
    Copy Markdown
    Member

    yungezz commented Jan 14, 2020

    hi @dkirby017 could you pls address review comments? let us know when your update done and ready for another review. thanks.

    @dkirby017
    Copy link
    Copy Markdown
    Member Author

    dkirby017 commented Jan 14, 2020

    @yungezz I did address the comments. Did I miss one?

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 14, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 15, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 15, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 15, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 15, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 15, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @dkirby017
    Copy link
    Copy Markdown
    Member Author

    dkirby017 commented Jan 15, 2020

    @yungezz @ryansbenson would someone be able to take another look at this now?

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 16, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 17, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 17, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 18, 2020
    @sanjaiganesh
    Copy link
    Copy Markdown
    Contributor

    sanjaiganesh commented Jan 18, 2020

    Adding ARMsignoff. pls add minor comments by Ryan

    @yungezz
    Copy link
    Copy Markdown
    Member

    yungezz commented Jan 19, 2020

    /azp run

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 19, 2020

    Azure Pipelines successfully started running 3 pipeline(s).

    This was referenced Jan 19, 2020
    Closed
    Closed
    Closed
    @yungezz
    Copy link
    Copy Markdown
    Member

    yungezz commented Jan 19, 2020

    hi @sanjaiganesh 204 response from non-delete operation was deleted already. I'm going to merge this PR if no further comments. add @ryansbenson also.

    @yungezz
    Copy link
    Copy Markdown
    Member

    yungezz commented Jan 20, 2020

    hi @dkirby017 is this PR ready the merge? is the service public now?

    @dkirby017
    Copy link
    Copy Markdown
    Member Author

    dkirby017 commented Jan 21, 2020

    @yungezz yes, this PR is ready to merge. we're still in public preview, but it is public rather than private :)

    @yungezz yungezz merged commit 53428a5 into Azure:master Jan 22, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @ryansbenson ryansbenson ryansbenson left review comments

    @yungezz yungezz yungezz approved these changes

    Assignees

    @yungezz yungezz

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    5 participants

    @dkirby017 @azuresdkci @yungezz @sanjaiganesh @ryansbenson